Fix for windows os error (#1402) Changed to use py3.6 behavior also with python 3.7 and above. #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch @mprostock, thanks for the PR! |
|
I do have some concerns about a variable called |
|
My brain didn't mind interpreting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1402.
Dash/Plotly work fine with python 3.5 and 3.6., but using python 3.7 creates uncaught OS Error exceptions from plotly utils.py.
Reason:
The variable PY36 in utils.py is used to branch code for different behaviour for datetime objects depending on the python version. This was set to 3.6 by using '==', this 1-character change ('>=') fixes the problems on windows when using plotly/dash with python 3.7. Without it 3.7 gets same behaviour as 3.5, which does not work. ;-)