Fix 3.8.0 responsive resizing behavior #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callbacks don't keep getting called. Restore default figure height of 525 Make iframe renderer responsive
|
dev build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1524
This PR fixes some regressions in responsive plot resizing that were introduced in 3.8.0.
I also tracked down a JavaScript error message that was being raised on resize. This led to figuring out how to explicitly cleanup the plotly graph_div elements when they are no longer visible in the notebook (output cell cleared or cell deleted). This may potentially reduce memory usage during long sessions where plots are repeatedly created and destroyed.
Finally, I also worked out how to make the new
iframerenderer resize responsively as well.