New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package listing in setup.py #1543

Merged

jonmmease merged 1 commit into plotly:master from jakevdp:fix-build

May 2, 2019

Contributor

jakevdp commented May 1, 2019 •

edited

Loading

The package listing in plotly's setup.py is non-standard; rather than file paths, it should list Python package paths (see https://docs.python.org/3/distutils/setupscript.html#writing-the-setup-script). This PR fixes the issue.

I tested this by running the following

$ python setup.py sdist
$ cat plotly.egg-info/top_level.txt
_plotly_future_
_plotly_utils
chart_studio
plotly
plotlywidget

The top-level package listing is now correct.


          Fix package listing in setup.py

8f451a2

Contributor

jonmmease commented May 2, 2019

Looks good, thanks @jakevdp!

jonmmease merged commit ec67e96 into plotly:master

jakevdp deleted the fix-build branch

May 2, 2019 14:40

jonmmease added this to the v3.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet