Fix honouring of validate=False for all renderers
#1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for digging in on this @matthewwardrop, I think you're right that this was an oversight. I'll take a closer look soon and pull this in for 3.10.0. Thanks! |
|
Thanks for the prompt response @jonmmease :). |
matthewwardrop
force-pushed
the
mw_fix_avoiding_validation
branch
from
8f2c170
to
20d91af
Compare
|
Looks great. Thanks again @matthewwardrop |
jonmmease
changed the title
validate=False for interactive plots.validate=False for all renderers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
We have been working with Plotly recently and attempting to plot Plotly JSON blobs generated from R in Python, and (as it happens) these blobs are not conformant to the Plotly JSON schema. Passing
validate=Falseto theplotly.offline.plotmethod works fine, but not forplotly.offline.iplot, due to validation being enabled by default for some of the rendering backends. One approach to fixing this would be to passvalidatedown to the renderers, but it appears based onvalidate=Falsebeing passed by default to some backends that this may have been an oversight in the default passed to these mimebundle renderers. This patch makes this consistent, and causes all mimebundle generations to no longer validate. Since validation would have happened earlier if not explicitly passingvalidate=False, I believe this should be okay.