responsive Gantt-chart #1724
Merged
responsive Gantt-chart #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gantt chart now uses scatter plots: - updating all the functions accordingly - unit tests updated - new param: show_hover_fill for hiding the text for the filled area
* only set plotlyServerURL using the plotly_domain in the .config file if one isn't specified in the config dict passed to iplot/plot * make it clear that the default in clean_config.get is None
* scraper function for sphinx-gallery, in plotly.io. scraper function + skeleton of sphinx doc with minimal gallery (two examples) * added psutil dep to tox.ini * python 2 compatibility * added orca dep to package.json for tests * removed typo * corrected bug * python 2 compatibility * added electron * try to configure orca * Moved test file so that it's tested by the orca build only. * use custom renderer for sphinx-gallery * removed sphinx files which are now in plotly-sphinx-gallery + changed name of renderer sphinx -> sphinx-gallery, and changed wording of documentation * Modified test with new renderer name * try to fix py2 compatibility * write_html instead of offline.plot * change import order
Gantt chart now uses scatter plots: - updating all the functions accordingly - unit tests updated - new param: show_hover_fill for hiding the text for the filled area
# Conflicts: # packages/python/plotly/plotly/tests/test_optional/test_figure_factory/test_figure_factory.py # packages/python/plotly/tox.ini
# Conflicts: # packages/python/plotly/plotly/figure_factory/_gantt.py # packages/python/plotly/plotly/tests/test_optional/test_figure_factory/test_figure_factory.py # packages/python/plotly/plotly/tests/test_optional/test_tools/test_figure_factory.py
legendgroups for markers marker opacity is 0
…None the created figure is now responsive
|
Hi @csabaszan, thanks for the PR. I'm happy for the gantt to be responsive horizontally by default. But I think we should keep the default height of 600 so that, in the notebook, gantt charts aren't displayed shorter than they are now. Does that work for you? If responsive height is also desired for HTML export, then the |
|
Hi @jonmmease, yeah only responsive width by default makes more sense to me as well. |
|
Thanks @csabaszan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
#1211 mentioned that the created figure is not responsive, so I removed the default values for width and height of the figure.
Csaba