Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed skimage import #1832

Merged
merged 6 commits into from
Oct 18, 2019
Merged

fixed skimage import #1832

merged 6 commits into from
Oct 18, 2019

Conversation

emmanuelle
Copy link
Contributor

Closes #1826 and #1829

@nicolaskruchten
Copy link
Contributor

So with this we just can’t see certain factories when the deps aren’t installed? Shouldn’t we just throw a call-time error instead? Otherwise someone will try to run the docs and be confused about import failures, no?

@nicolaskruchten
Copy link
Contributor

Or does “optional imports” warn or something?

@emmanuelle
Copy link
Contributor Author

We can probably import the dep inside the ff function instead, yes. I just copied the behaviour which was used for pandas and county_choropleth, I did not give it much thought

@nicolaskruchten
Copy link
Contributor

💃

@emmanuelle emmanuelle merged commit ff23511 into master Oct 18, 2019
@emmanuelle emmanuelle deleted the fix_imports branch March 31, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does Plotly 4.2.0 depend on scikit-image?
2 participants