-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server_url to plotly.io.orca to allow for external orca server #1850
Conversation
Thanks @miriad! We'll try to take close look soon, and we should be able to get this in for version 4.3.0 (probably a week or two out). |
@miriad @jonmmease any idea of how to add tests for this? Open a local orca server and communicate with it? |
That's something I struggled with, because of the need to run an external service. Seemingly, running a local orca server and communicating with it via localhost would be sufficient. |
Looks great @miriad. I added a test, made a couple small cleanup changes, and merged master. I'm very glad to have this option available now. Thanks! |
Hello, I have tried to configure the external server by means of setting up the new available property 'server_url' but after doing it like this:
The property 'executable' does not change to 'None' so the executable continues being required. After debugging I have seen that the setter does not change the property since self._props is empty.
Maybe I am not configuring it correctly. |
I can confirm that it just doesn't work. |
Please try including the port directly in server_url, such as "localhost:9091" The port field is intended for use with a locally managed server, and setting will override the server_url field |
Please find my comment in above mentioned issue. |
Opened PR for fixing that: #1915 |
Add server_url to plotly.io.orca.config to allow an external orca server.
Implementation of #1570