-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the default template's background color for swatches #1872
Conversation
Looks good to me if you can fix the formatting problem in CI? |
I believe this is the same CI error as on the other PRs and unrelated to the changes I have made. The error is
I think that line 256 might need to have |
If you want to have this check the |
re the synergization of px and pio templates... Really the way to do this would be to rewrite this little swatch function on top of |
the plot titles are also pretty ugly at the moment... they used to say |
Instead of always using the plotly template
b8606ae
to
523ff96
Compare
523ff96
to
d291d3a
Compare
Closing since #1886 was merged, thanks @joelostblom ! |
This is a suggestion to use the default template's background color for swatches Instead of always using the plotly template. The potential benefit of this change would be that it is easier to tell which colors sequence go well with the currently used template.
It would be neat if this also checked if there was a PX template set, and I asked a related question about how PX and PIO templates synergize in #1869.
Screenshots: