Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "paper" as default reference when adding annotations/shapes/images #1888

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

jonmmease
Copy link
Contributor

@jonmmease jonmmease commented Nov 11, 2019

This PR updates add_annotations/add_shapes/add_images so that if no row/col are specified, the xref/yref properties are left unset rather than being set to "paper". Now, to use add_annotations to add an annotation in "paper" coordinates you leave row/col unset and simply pass xref="paper" and yref="paper kwargs.

Similarly, select_annotations no longer accepts row="paper"/col="paper. Instead, to select only the annotations in paper coordinates, you would use xref="paper", yref="paper" in the selector.

@nicolaskruchten

Closes #1881

pin black version in pre-commit-config.yaml
don't support setting row/col to "paper", instead use xref/yref="paper"
@nicolaskruchten
Copy link
Contributor

@emmanuelle this resolves this issues you raised right? 💃 from me if so!

@emmanuelle
Copy link
Contributor

Yes, looks good ! 💃 I might have to update the doc tutorial.

@emmanuelle emmanuelle added this to the v4.3.0 milestone Nov 11, 2019
@jonmmease jonmmease merged commit f785746 into master Nov 11, 2019
@nicolaskruchten nicolaskruchten deleted the add_annotation_default branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xref/yref in annotation/shape/image without row/col
3 participants