Remove "paper" as default reference when adding annotations/shapes/images #1888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
add_annotations
/add_shapes
/add_images
so that if norow
/col
are specified, thexref
/yref
properties are left unset rather than being set to"paper"
. Now, to useadd_annotations
to add an annotation in "paper" coordinates you leaverow
/col
unset and simply passxref="paper" and yref="paper
kwargs.Similarly,
select_annotations
no longer acceptsrow="paper"
/col="paper
. Instead, to select only the annotations in paper coordinates, you would usexref="paper"
,yref="paper"
in theselector
.@nicolaskruchten
Closes #1881