adding pie, treemap, sunburst, funnel and funnelarea to px

[emmanuelle]

No description provided.

[nicolaskruchten]

This is all pretty good, modulo inline comments.

I'd really like to have support for color in pie/funnel/treemap/sunburst the day we release this though... I feel like adding continuous-color support for treemap/sunburst should be pretty trivial (i.e. it should "just work") and then discrete-color support will be harder because for these 4 traces it doesn't work at all the way it does in the other traces: it's not "groupable". But we should try to do it anyway :)

[nicolaskruchten]

I'd really like to have support for color in pie/funnel/treemap/sunburst the day we release this

This would basically be the "value added" of PX for these traces IMO, as compared to using the graph objects directly, so that's why I think it's important :)

[nicolaskruchten]

The way I would implement discrete color is basically in make_trace_kwargs with another gross type-specific exception inside the elif k == "color": block, which would just hardcode the marker colors.

[nicolaskruchten]

Extra requirement: if color_discrete_sequence is passed into pie/funnelarea/treemap/sunburst, we should probably assign it to layout.<whatever>colorway, so that something like px.pie(values=[1,2,3], color_discrete_sequence=["red", "green", "blue"]) will do the expected thing.

[emmanuelle]

Hum, interesting to see that the test fail because the color of the funnel is not the same.

[emmanuelle]

Do we want to accept color_discrete_sequence='Viridis'? At the moment it only works with a px object.

[nicolaskruchten]

it's normal that color_discrete_sequence only works with an array of colors, yes. It's not clear what we would do if we got Viridis, as that scale doesn't have a fixed number of categorical colors...?

[emmanuelle]

ok good, so nothing more to do for this :-).

[nicolaskruchten]

@emmanuelle some tweaks in that last commit, LMK what you think.

[emmanuelle]

Oh interesting, I did not know that marker_colors could be a dictionary, I thought it had to be a list/array.

[nicolaskruchten]

I think it does have to be a list, and in this case it is...?

[nicolaskruchten]

this is the same code you had, just inlined :)

[emmanuelle]

oh yes I had read too fast!

[emmanuelle]

Thanks, looks good to me. Should we give each other a 💃 ? :-)