New mapbox functions in PX #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And then we'll need to update some docs to show off the new functions! |
nicolaskruchten
commented
Dec 2, 2019
| constructor=go.Choroplethmapbox, | ||
| trace_patch=dict( | ||
| geojson=geojson | ||
| if not hasattr(geojson, "__geo_interface__") |
There was a problem hiding this comment.
this is geopandas-specific code so that you can just say ...geojson=geo_df.geometry... :)
|
Exactly if the doc migration PR is merged then you can add directly the updates to the doc! |
|
So the percy script fails because it's missing the |
|
Hah, yes, hurray tests :) |
|
💃, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll add a couple of tests here and then this should be good to go :)