Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix facet labels #1966

Merged
merged 1 commit into from
Dec 4, 2019
Merged

fix facet labels #1966

merged 1 commit into from
Dec 4, 2019

Conversation

nicolaskruchten
Copy link
Contributor

Closes #1944

@nicolaskruchten nicolaskruchten mentioned this pull request Dec 3, 2019
Closed
emmanuelle
emmanuelle reviewed Dec 4, 2019
View reviewed changes
packages/python/plotly/plotly/tests/test_core/test_px/test_px.py
facet_col="day",
color="size",
symbol="sex",
labels={c: c[::-1] for c in tips.columns},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not :-)

@emmanuelle
Copy link
Contributor

Thanks 💃

@nicolaskruchten nicolaskruchten merged commit c31802f into master Dec 4, 2019
@nicolaskruchten nicolaskruchten added this to the v4.4.0 milestone Dec 10, 2019
@nicolaskruchten nicolaskruchten deleted the facet_labels branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.4.0
Development

Successfully merging this pull request may close these issues.

PX facet labels don't respect labels kwarg
2 participants
@nicolaskruchten @emmanuelle