Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Px should not hardcode height #1990

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Px should not hardcode height #1990

merged 2 commits into from
Dec 10, 2019

Conversation

nicolaskruchten
Copy link
Contributor

No description provided.

jonmmease
jonmmease approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I reviewed and approved the Percy changes and added a CHANGELOG entry

@jonmmease jonmmease merged commit de05925 into master Dec 10, 2019
@jonmmease jonmmease deleted the nicolaskruchten-patch-5 branch December 10, 2019 13:00
@nicolaskruchten nicolaskruchten added this to the v4.4.0 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmmease jonmmease jonmmease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolaskruchten @jonmmease