More flexible parallel_categories magic #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
nicolaskruchten
force-pushed
the
dimensions_max_cardinality
branch
from
0279856
to
74184e0
Compare
emmanuelle
reviewed
Jan 21, 2020
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
emmanuelle
reviewed
Jan 21, 2020
|
I left a suggestion, feel free to add it or not, 💃 |
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
|
Awesome, thanks :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2008 by:
dimensions_max_cardinalitycutoff in kwargsdimensionsfrom the cutoffThis means that a user can now do
px.parallel_categories(tips, dimensions=["smoker", "total_bill"])if they like and get both columns in the output even thoughtotal_billhas more than 50 unique values. The user can also now dopx.parallel_categories(tips, dimensions_max_cardinality=1000)to get similar output to parallel coordinates although less readable/useful.@emmanuelle if you like this approach to solving the problem I'll add some tests and docs.