Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Px bool #2127

Merged
merged 6 commits into from
Mar 11, 2020
Merged

Px bool #2127

merged 6 commits into from
Mar 11, 2020

Conversation

emmanuelle
Copy link
Contributor

Closes #2121

@emmanuelle
Copy link
Contributor Author

Tests pass but one the other hand none of our datasets has a bool column I think...

@nicolaskruchten
Copy link
Contributor

unfortunately this fails for px.sunburst(path=[["yes", "no", "no"],["yes", "no", "a"]], color=[True, False, True]) for reasons that aren't super-clear to me at this point.

@nicolaskruchten
Copy link
Contributor

interestingly, passing boolean color to sunburst works on master: it's treated as if it were 1s and 0s.

@nicolaskruchten nicolaskruchten mentioned this pull request Feb 4, 2020
Merged
@emmanuelle
Copy link
Contributor Author

The problem with sunburst has been fixed, this one should be ready for review.

@nicolaskruchten
Copy link
Contributor

💃 when green!

@emmanuelle
Copy link
Contributor Author

ok, do you want to greenify percy yourself to accept the new visuals?

@emmanuelle emmanuelle merged commit 307fd73 into master Mar 11, 2020
@emmanuelle emmanuelle deleted the px-bool branch March 27, 2020 16:28
@nicolaskruchten nicolaskruchten modified the milestone: v4.6.0 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coloring by boolean column type does not work
2 participants
@emmanuelle @nicolaskruchten