Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update facet-plots.md #2235

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Update facet-plots.md #2235

merged 3 commits into from
Mar 4, 2020

Conversation

SylwiaOliwia2
Copy link
Contributor

Added section 'Zooming subplots to the same range'. A part of #1965

Added section 'Zooming subplots to the same range'
@@ -118,3 +118,20 @@ fig.show()
```python

```

### Zooming subplots to the same range
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches does actually more than synchronizing zoom, you also have synchronized panning for example. How about a more general title like "Synchronizing axes in subplots with matches"? Also what do you think of mentioning pan and zoom in the text below (compared to just zoom at the moment?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I will edit the title and mention the pan.

@emmanuelle
Copy link
Contributor

Thanks a lot @SylwiaOliwia2 for this nice example! The example is great, I left a suggestion on how to make the text a little more general, please tell me what you think.

SylwiaOliwia2 and others added 2 commits March 3, 2020 05:57
Fix Typo

Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Update 'Synchronizing axes in subplots with matches' title; mention pan in this section.
@emmanuelle
Copy link
Contributor

Thank you very much! Merging :-).

@emmanuelle emmanuelle merged commit 5bf1530 into plotly:doc-prod Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants