-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apigen recursive #2243
Apigen recursive #2243
Conversation
@@ -2251,8 +2251,8 @@ | |||
"dev": true, | |||
"optional": true, | |||
"requires": { | |||
"co": "^4.6.0", | |||
"json-stable-stringify": "^1.0.1" | |||
"co": "4.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes to this file probably should be reverted.
@jonmmease, one thing I can't get my head around is which part of the codegen generates the docstrings of the |
The doc build is a bit long (a few minutes), but the build is stored in the artifacts of CircleCI if you want to take a look. |
@emmanuelle, the property docstrings are generated dynamically during codegen by |
@jonmmease absolutely! I was grepping only the |
So with this PR we get these extra directives in the docstrings that people will see when they try help(object) in a notebook? |
@nicolaskruchten yes we'll have the extra directives. However I found out that we can use |
I can live with |
I could also attach a helper function to |
Ready for review! |
.circleci/config.yml
Outdated
@@ -472,6 +472,7 @@ jobs: | |||
git config user.name plotlydocbot | |||
git config user.email accounts@plot.ly | |||
git add * | |||
git add * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum let me fix this
💃 ! This is great :) |
still WIP, and it's been some time since I worked on this. Basically the idea is to call
sphinx-apidoc
to generate all the doc pages.