Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: fix python 3.8 Syntax Warning #2262

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

sgn
Copy link
Contributor

@sgn sgn commented Mar 10, 2020

Closes #2230

@sgn sgn force-pushed the python-3.8-warning branch from 1627907 to a63b38d Compare March 11, 2020 00:26
@nicolaskruchten
Copy link
Contributor

This looks great, thank you! It will go out as part of the 4.5.4 release today :)

@nicolaskruchten nicolaskruchten merged commit 262932b into plotly:master Mar 11, 2020
@nicolaskruchten nicolaskruchten modified the milestone: v4.5.2 Mar 11, 2020
@lewi0332
Copy link

Hi all,

I am also seeing this same issue in the chart-studio tools.py file. Sorry if this isn't the right place, but I didn't see a chart studio specific issues spot.

chart-studio==1.1.0.

2021-05-12T14:51:57.985399+00:00 app[web.1]: /app/.heroku/python/lib/python3.9/site-packages/chart_studio/tools.py:290: SyntaxWarning: "is" with a literal. Did you mean "=="?
2021-05-12T14:51:57.985401+00:00 app[web.1]:   if share_key is "":

Additionally I'm not actually calling for Chart-studio to be installed, it is being added by a pip requirement of something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyinstaller shows SyntaxWarning: "is" with a literal. Did you mean "=="?
3 participants