-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sankey-diagram.md #2291
Update sankey-diagram.md #2291
Conversation
This is a very nice example, thank you so much @SylwiaOliwia2 ! Could you please add a few explanations:
I also left an inline suggestion. |
Thank you very much @SylwiaOliwia2 ! Can you also change the title? If you can't do it now, I think I'll merge this afternoon and we can change the title later, since a question on the user forum would benefit from your example :-) 🎉 (https://community.plotly.com/t/how-to-set-the-color-of-sankey-diagram-lines/36766 - what a timing!) |
On my way to do it @emmanuelle. Just try to update the branch to pass all the tests. Even if it's not necessary, I want to improve my skills. I guess in the evening it will be ready to merge along with the changed title :) |
Add colorful links to the Sankey diagram.
More complex Sankey diagram with colored links - setting the link color in one line, add the comment why 'magenta' is changed to its rgba value. Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
I've changed the title. The test |
thanks @SylwiaOliwia2 I'm merging. You would need to merge master (after pulling) to get the commit which fixes the python-2.7 build but it's ok, it is already in master so no problem for merging here. Thanks again! |
Add colorful links to the Sankey diagram.
#1965
Please uncomment this block and take a look at this checklist if your PR is making substantial changes to documentation/impacts files in the
doc
directory. Check all that apply to your PR, and leave the rest unchecked to discuss with your reviewer! Not all boxes must be checked for every PR :)doc/README.md
filedoc-prod
branch OR it targets themaster
branchpx
example if at all possibleplotly.graph_objects as go
/plotly.express as px
/plotly.io as pio
df
fig = <something>
call is high up in each new/modified example (eitherpx.<something>
ormake_subplots
orgo.Figure
)fig.add_*
andfig.update_*
rather thango.Figure(data=..., layout=...)
in every new/modified examplefig.add_shape
andfig.update_xaxes
are used instead of bigfig.update_layout
calls in every new/modified examplefig.show()
is at the end of each new/modified exampleplotly.plot()
andplotly.iplot()
are not used in any new/modified example