Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port cufflinks #2325

Merged
merged 5 commits into from
Mar 27, 2020
Merged

Port cufflinks #2325

merged 5 commits into from
Mar 27, 2020

Conversation

nicolaskruchten
Copy link
Contributor

@emmanuelle
Copy link
Contributor

CI fails with

Checking... are there posts with order > 5 and 'page_type: example_index'?
NOT PASSED!

for the new tutorial

@emmanuelle
Copy link
Contributor

did you merge my recent chart-studio fixes and is it something different for the 2.7 CI failure?

@nicolaskruchten
Copy link
Contributor Author

This is in doc-prod so your fixes have not been applied yet, no, not until the next release.

emmanuelle
emmanuelle reviewed Mar 27, 2020
View reviewed changes
doc/python/cufflinks.md Outdated Show resolved Hide resolved
emmanuelle
emmanuelle reviewed Mar 27, 2020
View reviewed changes
doc/python/cufflinks.md Outdated Show resolved Hide resolved
@emmanuelle
Copy link
Contributor

Looks good! It could be nice to add an example calling fig.update_layout or update_traces after calling iplot but this can be done later so 💃

nicolaskruchten and others added 2 commits March 27, 2020 12:14
@nicolaskruchten @emmanuelle
Update doc/python/cufflinks.md
031f6cd 
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
@nicolaskruchten @emmanuelle
Update doc/python/cufflinks.md
67bab59 
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
@nicolaskruchten nicolaskruchten merged commit 1947798 into doc-prod Mar 27, 2020
@nicolaskruchten
Copy link
Contributor Author

Thanks!

@nicolaskruchten nicolaskruchten deleted the cufflinks branch June 19, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolaskruchten @emmanuelle