Sg scraper #2419
Merged
Sg scraper #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and separate source directory
|
oops I need to fix the tests! |
|
💃 when the tests pass, so long as this is confirmed to be a backwards-compatible change ... ? |
|
yes this is backward-compatible! Just a less convoluted (and more robust for some galleries) way of scraping png and html files. |
|
Oops forgot to ask for a change log item :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement of the sphinx-gallery scraper, which crawls only the directory of the example and now works for different structures of galleries (I was trying to add a plotly example to the gallery of scikit-image and it did not work with the scraper, with this change it is working).
A more sustainable mid-term change would be to add a
_repr_html_method to theBaseFigureclass (since the html would then be captured by sphinx-gallery) but for now the scraper works.