Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug_2931: resolving numpy integer check and adding test #2451

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

MCBoarder289
Copy link
Contributor

@MCBoarder289 MCBoarder289 commented May 8, 2020

Thanks to @emmanuelle for directing where this fix would live and even some code to make it work!

I also looked for similar checks and found some in subplots.py, but by that time this check must have already passed since I'm using subplots in my unit test.

Also considered if we should leverage what is in packages\python\plotly\_plotly_utils\basevalidators.py for coercion, but opted for this simple import try. Open to all feedback on how to improve this PR!

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@nicolaskruchten
Copy link
Contributor

Thanks! I'm sorry we haven't been communicative on your PRs... we've been a bit backlogged these days, but I'll try to get them merged in for our upcoming 4.8 release on Tuesday :)

@MCBoarder289
Copy link
Contributor Author

You’re welcome, just glad I could help contribute! Looking forward to hearing back any feedback you all have.

@emmanuelle
Copy link
Contributor

Thanks a lot @MCBoarder289 ! Sorry for the time it took to review, I'll try to do better for your next patch ;-). Thanks again.

@emmanuelle emmanuelle merged commit 267c187 into plotly:master Jun 3, 2020
@nicolaskruchten nicolaskruchten added this to the 4.8.2 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants