bug_2931: resolving numpy integer check and adding test #2451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @emmanuelle for directing where this fix would live and even some code to make it work!
I also looked for similar checks and found some in subplots.py, but by that time this check must have already passed since I'm using subplots in my unit test.
Also considered if we should leverage what is in
packages\python\plotly\_plotly_utils\basevalidators.py
for coercion, but opted for this simple import try. Open to all feedback on how to improve this PR!Code PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).