Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug_2410: Allowing Ints to be passed for rows/cols and refactored int… #2546

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

MCBoarder289
Copy link
Contributor

@MCBoarder289 MCBoarder289 commented Jun 6, 2020

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

Changes in this PR:

  • Now allowing the "add_traces" method to take single integers for the rows/cols parameters.
  • Also refactored the numpy integer check to be more reusable, and added more tests

Fixes #2410

@nicolaskruchten nicolaskruchten added this to the 4.8.2 milestone Jun 8, 2020
@nicolaskruchten nicolaskruchten modified the milestones: 4.8.2, 4.9.0 Jun 22, 2020
@emmanuelle
Copy link
Contributor

Thank you very much @MCBoarder289 ! I've left a cosmetic comment about the docstring but this looks ready to me!

MCBoarder289 and others added 2 commits June 22, 2020 16:38
Quick cosmetic update to the docstring

Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
Quick cosmetic update to the docstring

Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
@MCBoarder289
Copy link
Contributor Author

Thank you for the review, @emmanuelle! I appreciate the feedback, and those changes are now committed.

@emmanuelle emmanuelle merged commit 33701df into plotly:master Jun 22, 2020
@nicolaskruchten
Copy link
Contributor

Ah, @emmanuelle I was thinking this would be in 4.9.0 rather than 4.8.2 but OK, it won't break anything for anyone :)

@nicolaskruchten nicolaskruchten modified the milestones: 4.9.0, 4.8.2 Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accept int for rows and cols in fig.add_traces
3 participants