make trendlines more robust #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelle
reviewed
Jun 12, 2020
emmanuelle
reviewed
Jun 12, 2020
| if x.dtype.type == np.datetime64: | ||
| x = x.astype(int) / 10 ** 9 # convert to unix epoch seconds | ||
| x_is_date = True | ||
| elif x.dtype.type == np.object_: | ||
| x = x.astype(np.float64) |
There was a problem hiding this comment.
Here if we have strings like the data column of px.data.stocks() this will raise an error message ValueError: could not convert string to float: '2018-01-01'. This is not a regression since the error message is better than the current one deep in statsmodels, but this line could be in a try except statement with an error message written by us.
There was a problem hiding this comment.
agreed, will fix
nicolaskruchten
force-pushed
the
trendline_fix
branch
from
594286e
to
2015d1a
Compare
nicolaskruchten
force-pushed
the
trendline_fix
branch
from
2015d1a
to
e823437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2549 (trendlines with zero slope) as well as a couple of other issues I found while testing: