Figure select function selector #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any function that calls BaseFigure._selector_matches can use a function as the selector. This includes the "Figure.for_each_*" functions, the "Figure.update_*" functions, and the "Figure.select_*" functions. See test_selector_matches.py for the behaviour of the selector argument.
|
Superseded by #2844 I imagine? Can close? |
|
I meant: supersedes #2836 therefore we can close that one! |
| else: | ||
| raise TypeError( | ||
| "selector must be dict or a function " | ||
| "accepting a trace returning a boolean." |
There was a problem hiding this comment.
this is now more than just "a trace" right? maybe "a graph object" ?
There was a problem hiding this comment.
ah yes, copy paste error! good catch 👍
|
Nicely done! 💃 when you address my comment about |
Now selector can accept any graph object
|
Looks great, please merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2629 and more.
Any function calling
BaseFigure._selector_matchescan now pass a function for theselectorargument. This function is called on each object and if it returns True, then that object is included in the selection.