go.Figure.set_subplots
#2866
Merged
go.Figure.set_subplots
#2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `fig.set_subplots(2,3)` works just like fig=make_subplots(2,3). Also accepts the same keywords arguments as make_subplots. Fails if fig already has subplots. Tests still need to be added.
nicholas-esterer
requested review from
nicolaskruchten and
emmanuelle
and removed request for
nicolaskruchten
|
@jonmmease mind taking a quick look here to see if everything makes sense? |
jonmmease
approved these changes
Nov 4, 2020
| assert fig1.layout == fig1_sp.layout | ||
| # Test that calling on a figure that already has subplots throws an error. | ||
| raised = False | ||
| try: |
There was a problem hiding this comment.
I'd recommend using with pytest.raises (https://docs.pytest.org/en/stable/assert.html#assertions-about-expected-exceptions) here as it's a little more concise.
There was a problem hiding this comment.
Originally I used pytest.raisesRegex but it broke the Python2 tests.
There was a problem hiding this comment.
Does the match argument to pytest.raises work with Python 2.7? e.g. pytest.raises(ValueError, match=r".* 123 .*").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2405
This is now possible
and
figgyis equivalent to what is given by:Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).