-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trendline options #2997
Merged
Merged
Trendline options #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskruchten
force-pushed
the
trendlines2
branch
from
May 25, 2021 15:12
b378ae6
to
bf09ebc
Compare
nicolaskruchten
force-pushed
the
trendlines2
branch
from
June 14, 2021 15:12
bf09ebc
to
962eaf5
Compare
nicolaskruchten
force-pushed
the
trendlines2
branch
from
August 2, 2021 00:39
962eaf5
to
b0ed4cf
Compare
nicolaskruchten
force-pushed
the
trendlines2
branch
from
August 4, 2021 01:26
8390632
to
e7a2fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors trendline code to extract a common interface (an ugly one!), including an
options
dict, which enables new functions like rolling mean (needed an argument for the window size at least!) and OLS options likelog_x
andadd_constant
, plus a configurable LOWESSfrac
parameter.Code PR
modified existing tests.
new tutorial notebook (please see the doc checklist as well).