-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support JupyterLab 3 in extensions #3016
Conversation
Don't forget to bump the |
(Technically it will still work since you've said it was a singleton and not bundled, but it will complain in the console nonetheless about the version not matching what you've required) |
Ah, didn't see this comment until now... Thanks! This will cause Javascript console warnings only basically? |
For now. In the future we plan to turn on strict versioning to be more accurate with our versions, which would mean this would fail then. |
OK, thanks! I'll get this fixed in the next version, which I expect will come soon, as this upgrade seemed "too easy" :P |
Hi @nicolaskruchten, Thanks for the update, works nicely ;) In the readme file I think the ipywidgets version should be >=7.6, otherwise it doesn't work in jlab v3 |
Actually, @nicolaskruchten - you should update the version number of |
ipywidgets can technically be < 7.6 - all 7.6 basically does is install widgets for jlab 3 by default. You can have ipywidgets 7.5 and install |
@jasongrout I was able to get it to work with all extensions installed as source extensions... |
Without updating your |
yeah, I just did |
(my only reticence is that it's late and it's about a 90-minute process to do a whole release BTW! I'll surely do it in the next few days) |
Yep, I just checked, and it luckily works out when we merge dependency configs to give the base 4.0 version. It may not be so lucky if we have two widgets installed as source extensions and the manager as prebuilt? In any case, there certainly is a technical issue (the build is pulling in two copies of widgets base, version 3 and version 4), though it seems that for some reason things seem to collapse to the right version in my test setup too. If you're releasing again in the next few days, I won't trace it further for now. It is a bit puzzling to me that it works, though. |
Hehe ok, thanks for digging! Sorry to distract you with a juicy puzzle ;) |
Thanks both! I've just released 4.14.3 with the |
Closes #2994