Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support JupyterLab 3 in extensions #3016

Merged
merged 1 commit into from
Jan 11, 2021
Merged

support JupyterLab 3 in extensions #3016

merged 1 commit into from
Jan 11, 2021

Conversation

nicolaskruchten
Copy link
Contributor

Closes #2994

@nicolaskruchten nicolaskruchten merged commit 3a6d2b1 into master Jan 11, 2021
@jasongrout
Copy link

jasongrout commented Jan 11, 2021

Don't forget to bump the @jupyter-widgets/base requirement in packages/javascript/plotlywidget/package.json

@jasongrout
Copy link

(Technically it will still work since you've said it was a singleton and not bundled, but it will complain in the console nonetheless about the version not matching what you've required)

@jasongrout
Copy link

@nicolaskruchten ^

@nicolaskruchten
Copy link
Contributor Author

Ah, didn't see this comment until now... Thanks! This will cause Javascript console warnings only basically?

@jasongrout
Copy link

This will cause Javascript console warnings only basically?

For now. In the future we plan to turn on strict versioning to be more accurate with our versions, which would mean this would fail then.

@nicolaskruchten
Copy link
Contributor Author

OK, thanks! I'll get this fixed in the next version, which I expect will come soon, as this upgrade seemed "too easy" :P

@Alexboiboi
Copy link

Alexboiboi commented Jan 11, 2021

Hi @nicolaskruchten,

Thanks for the update, works nicely ;)

In the readme file I think the ipywidgets version should be >=7.6, otherwise it doesn't work in jlab v3

@jasongrout
Copy link

Actually, @nicolaskruchten - you should update the version number of @jupyter-widgets/base now. You'll have problems now if they install @jupyter-widgets/jupyterlab-manager as a source extension if you don't update. Things will work (with complaining) only if they install the widget manager as a prebuilt extension.

@jasongrout
Copy link

In the readme file I think the ipywidgets version should be >=7.6, otherwise it doesn't work in jlab v3

ipywidgets can technically be < 7.6 - all 7.6 basically does is install widgets for jlab 3 by default.

You can have ipywidgets 7.5 and install jupyterlab_widgets 1.0 to get widgets in jlab 3, for example.

@nicolaskruchten
Copy link
Contributor Author

@jasongrout I was able to get it to work with all extensions installed as source extensions...

@jasongrout
Copy link

@jasongrout I was able to get it to work with all extensions installed as source extensions...

Without updating your @jupyter-widgets/base requirement to include ^4?

@nicolaskruchten
Copy link
Contributor Author

yeah, I just did jupyter labextension install @jupyter-widgets/jupyterlab-manager then jupyter labextension install plotlywidget@4.14.2 and it worked out. Did that somehow install a prebuilt version of the manager?

@nicolaskruchten
Copy link
Contributor Author

(my only reticence is that it's late and it's about a 90-minute process to do a whole release BTW! I'll surely do it in the next few days)

@jasongrout
Copy link

Yep, I just checked, and it luckily works out when we merge dependency configs to give the base 4.0 version. It may not be so lucky if we have two widgets installed as source extensions and the manager as prebuilt?

In any case, there certainly is a technical issue (the build is pulling in two copies of widgets base, version 3 and version 4), though it seems that for some reason things seem to collapse to the right version in my test setup too.

If you're releasing again in the next few days, I won't trace it further for now. It is a bit puzzling to me that it works, though.

@nicolaskruchten
Copy link
Contributor Author

Hehe ok, thanks for digging! Sorry to distract you with a juicy puzzle ;)

@nicolaskruchten
Copy link
Contributor Author

Thanks both! I've just released 4.14.3 with the package.json changes requested and I've lightly edited the readme/getting-started docs so as to reduce the likelihood that someone will have a bad/incompatible version of ipywidgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyterlab 3.x.x support
3 participants