Fix: customdata is sometimes a tuple #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a figure to store numpy arrays with Object dtype again
|
Thanks! Any chance that this degrades performance somehow or anything? |
No, I don't think so. The conversion to the tuple form would actually have been a performance hit. Serialization now has to perform the conversion, but that's what it would have needed to do before. |
|
OK, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #3292
The regression was that numpy/pandas arrays with Object
dtypewere getting converted into Python lists when added to aFigure. This was caused by an unnecessary changed I made in the JSON serialization PR in commit 6cea61d.This PR is largely a manual revert of that commit, with an added test to make sure serialization is still behaving properly when object arrays are included in a figure.