Fix error in orjson engine when a dict has a non-string value as a key #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Python's built-in json library can handle encoding dictionaries with keys that aren't strings by coercing them to strings implicitly. The orjson library requires the keys to be strings, otherwise an error is raised.
This would very rarely come up in plotly figures. But now that we're updating Dash (for Dash 2) to use the active plotly.py json engine, it comes up on occasion.
Change
All dict keys are converted to strings during the existing cleaning pass that is used prior to orjson encoding.
Tests
Test added that encodes a dict with integer keys.