-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dash-bio docs posts #3409
dash-bio docs posts #3409
Conversation
by not sorting keys (in either json engine) Add orjson OPT_NON_STR_KEYS and remove manual string conversion
Do not sort keys during json serialization
Unfortunately this straightforward approach will not work to display or document dash apps in this framework... let's discuss on Slack after the launch webinar on Wednesday :) |
We were worried about same thing, tho we thought we'll try simplistic approach first ^^. We saw other dash examples use iframe wrapped inside |
remove `dash` and `jupyter-dash`
add `no_display=true` to iframed cell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready for initial PR @emmeb
We probably need more stuff in Alignment Viewer but we've ran out of ideas and time - I tried implementing table similar to the one in Alignment Viewer, but with 40*300 cells to dispaly the performance was bismal, I briefly looked at heatmap, but seems like we wouldn't be able to display any letters on top of color map.
Let me know if you have other ideas.
I definitely skimped on the amount of text/content, sorry for that, I hope you could help me with that?
Overall this looks great! Going to send over some text to add to all the sections. Couple of small fixes:
|
doc/python/bio-manhattanplot.md
Outdated
order: 1 | ||
page_type: u-guide | ||
permalink: python/volcano-plot/ | ||
thumbnail: thumbnail/volcano-plot.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permalink: python/manhattan-plot/
thumbnail: thumbnail/manhttan-plot.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - I can add the thumbnails, which are sourced from our S3 bucket, as long as they have the correct path.
Once we know which ones we want to add to begin with, feel free to send me the thumbnails and I can upload them so that they're displayed on the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HammadTheOne we've dumped all image files here
all_static/images/alignment_chart.png
all_static/images/circos.png
all_static/images/clustergram.png
all_static/images/molecule_3d_viewer.png
all_static/images/volcano_plot.png
try to pin down doc deps
Co-authored-by: HammadTheOne <30986043+HammadTheOne@users.noreply.github.com>
Co-authored-by: HammadTheOne <30986043+HammadTheOne@users.noreply.github.com>
Co-authored-by: HammadTheOne <30986043+HammadTheOne@users.noreply.github.com>
@nicolaskruchten please take a look at logs from failing build stage
please advise if I can help with fixing |
The build on |
looks like this branch has been merged with the master after your commits: e91ba8a |
Right, those commits fixed the build on master. Now it's broken in this PR so it seems to me there's a problem with the changeset in this PR... |
build has successfully passed sorry for bothering you @nicolaskruchten , looks like it was a false alarm afterall |
these changes are comming in separate PR: plotly/graphing-library-docs#154 |
OK, build is green, merging. The pages will appear at their target URLs within around 20 minutes. You'll have to complete the graphing-library-docs PR to get the new section up etc though. |
added dash-bio docs posts for dash-graphing-library:
Couldn't assign @emmeb as a reviewer, so I'm tagging instead. @smallstepman for visibility.