Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setting config for MathJax v2 - ensure version 2 Hub #3706

Merged
merged 2 commits into from
May 3, 2022

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 3, 2022

@@ -826,9 +826,13 @@ export class FigureView extends DOMWidgetView {
this.model.on("change:_py2js_update", this.do_update, this);
this.model.on("change:_py2js_animate", this.do_animate, this);

// MathJax configuration
// MathJax v2 configuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a v3 equivalent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💃

@nicolaskruchten
Copy link
Contributor

Thanks!

@nicolaskruchten nicolaskruchten merged commit cbfa30d into master May 3, 2022
@archmoj archmoj deleted the fixup-mathjax-v2-config branch May 3, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants