allow non-string extras in flaglist attributes #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
May 26, 2022
| @@ -286,7 +286,7 @@ def get_latest_publish_build_info(repo, branch): | |||
|
|
|||
| url = ( | |||
| r"https://circleci.com/api/v1.1/project/github/" | |||
| r"{repo}/tree/{branch}?limit=10000\&filter=completed" | |||
| r"{repo}/tree/{branch}?limit=100&filter=completed" | |||
There was a problem hiding this comment.
After I remove the \ that makes its way into the final URL but before changing the limit value, this returns:
{
"message" : "limit must be between 0 and 100"
}
I don't know what set of jobs this was returning when the \ was there, looked recent but somehow didn't include any publish-dist jobs. 🤷 anyway now it seems to work locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support plotly/plotly.js#6193
modified existing tests.