Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PX: Avoid groupby when possible and access groups more efficiently #3765

Merged
merged 15 commits into from
Jun 23, 2022
Merged

PX: Avoid groupby when possible and access groups more efficiently #3765

merged 15 commits into from
Jun 23, 2022

Commits on Jun 8, 2022

  1. short circuit more machinery when one_group

    @nicolaskruchten
    nicolaskruchten committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    9941749 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. more correct optimization

    @nicolaskruchten
    nicolaskruchten committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b97d197 View commit details
    Browse the repository at this point in the history

  2. ♻️ check for all same groups

    @jvdd
    jvdd committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    6640d8f View commit details
    Browse the repository at this point in the history

  3. 🐛 make orders and sorted_group_names backwards compatible

    @jvdd
    jvdd committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    73b3c7c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #3767 from jvdd/one_group_short_circuit 

    ♻️ check for all same groups
    @nicolaskruchten
    nicolaskruchten committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    dd2137b View commit details
    Browse the repository at this point in the history

  5. reorder computation to avoid an extra scan through the data

    @nicolaskruchten
    nicolaskruchten committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    3ae0645 View commit details
    Browse the repository at this point in the history

  6. optimize group access

    @nicolaskruchten
    nicolaskruchten committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    067d4b0 View commit details
    Browse the repository at this point in the history

  7. slicing seems ambitious

    @nicolaskruchten
    nicolaskruchten committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9498396 View commit details
    Browse the repository at this point in the history

  8. trying again with groups

    @nicolaskruchten
    nicolaskruchten committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    35dbbe8 View commit details
    Browse the repository at this point in the history

  9. possible fix

    @nicolaskruchten
    nicolaskruchten committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    cdae77c View commit details
    Browse the repository at this point in the history

  10. 🧹 avoid unnecessary one_group groupby operations

    @jvdd
    jvdd committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b3a4583 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Merge pull request #3769 from jvdd/one_group_short_circuit 

    🧹 avoid unnecessary one_group groupby operations
    @nicolaskruchten
    nicolaskruchten committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    3043324 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Merge branch 'master' into one_group_short_circuit

    @nicolaskruchten
    nicolaskruchten committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    f97f2d2 View commit details
    Browse the repository at this point in the history

  2. changelog

    @nicolaskruchten
    nicolaskruchten committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    f46f809 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into one_group_short_circuit

    @nicolaskruchten
    nicolaskruchten committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    4b22199 View commit details
    Browse the repository at this point in the history