Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify utf-8 in script tag #4114

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Specify utf-8 in script tag #4114

merged 1 commit into from
Mar 28, 2023

Conversation

not522
Copy link
Contributor

@not522 not522 commented Mar 17, 2023

In our project (Optuna), plotly shows garbled text because of no specification for the encoding. This PR set charset to utf-8 in the script tag.

related issues:

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@archmoj
Copy link
Contributor

archmoj commented Mar 20, 2023

Thanks for the PR.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants