Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop notebook 6 #4805

Closed
wants to merge 6 commits into from
Closed

Drop notebook 6 #4805

wants to merge 6 commits into from

Conversation

marthacryan
Copy link
Collaborator

@marthacryan marthacryan commented Oct 16, 2024

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

  • Checkout branch
  • Create a new python env (conda, mamba, pipenv, etc)
  • git clean -f -x -d
  • cd packages/python/plotly
  • pip install -e .
  • pip install jupyter
  • Try it out in jupyter lab: jupyter lab
  • Try it out in jupyter notebook: jupyter notebook

@gvwilson gvwilson added feature something new P1 needed for current cycle labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants