-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop notebook 6 #4822
Merged
Merged
Drop notebook 6 #4822
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e7b6d7a
Add warning message when notebook version < 7 is used
marthacryan 590a4db
Move files under python/plotly
marthacryan cd7d587
remove old javascript and fix install
marthacryan 4f2ce95
Remove nbextension
marthacryan 0f16f0c
remove all jupyter extension code
marthacryan 5eff0ca
Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
marthacryan 612ceec
Merge with anywidget branch
marthacryan cb488ff
Remove npm from release instructions
marthacryan 4096595
Remove more references to jupyterlab-plotly
marthacryan f8fe306
Merge with anywidget
marthacryan 3f6c8f7
Fix filepath to js bundle in setup.py
marthacryan 5b97f05
Install before running npm build in ci
marthacryan 3b94298
Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
marthacryan 513798b
Remove npm pack of jupyterlab extension
marthacryan 39e65af
Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
marthacryan 25cbf52
Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
marthacryan 8e3354d
Update path of bundle in setup.py
marthacryan 60cc98f
update contributing to include new build instructions
marthacryan 3d2a234
Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
marthacryan 4759697
Merge with anywidget
marthacryan f6f2691
Remove more references to old jupyter support from README
marthacryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab