Don't crash if figure_factory is imported but pandas isn't installed #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good to me, thanks! @Kully - can you review too? |
Yes! 👍 |
|
Looks good to me. 💃 Note: It looks like your commit here is not fully addressing the original issue that you made. - i.e. Adding Pandas to the Required Dependancies - but for fixing the crash upon import I'm all for. |
Kully
added a commit
that referenced
this pull request
Mar 8, 2018
Changelog/version bump for PR #958
jonmmease
pushed a commit
that referenced
this pull request
Apr 18, 2018
* Update CHANGELOG.md * (matplotlylib) Make convert_dash more robust to changes in matplotlib. Now handles the case where the dashes are scaled, have floating-point values, or were customized with `dashes=(N,M)`. * commit * remove unnecessary data files in tests and robust data-path searching * pep-8: l -> L variable name * bump version number up * remove shapefiles from folders and delete folders * removed data/ folder and modified choropleth code to match file names * changelog for fixed 2.4.1 * chelsea's comments * added fill_percent to params for insert, swap and remove * html preview not working * HTML preview now reflects the fill_percent param settings * tests are working * make update_default_schema * udpated changelog, removed TODOs, PEP-8 79 char line limit * turn off hover for the lines * 0-padding * changelog * update changelog and version number for 2.5.0 * change fill_percent example in doc to fill_percent=20 * sort all node generators to make HTML output consistent for py2 + py3 * dashboards now autosize based on GUI * update dash workshop announcement cc @chriddyp * version num to 2.5.0 * 4 equal height vertical stacked example in doc string * rename box_1 to box_a, etc * remove shapefiles in tests dir * change version back for testing purposes * version to 2.5.0 * try bumping npm v in circle.yml to 6.0.0 * Don't crash if figure_factory is imported but pandas isn't installed. Fixes #941 * pr for #958 PR * add PR reference * remove a comment * update plotlyjs for offline * moved py2.7 test env to last in core environments * remove ipyplotly folder * fixed assert Scatter() == dict(type='scatter') * fixed test_access_top_level in test_figure * more in test_figures fixes * remove junk in test_figure.py from before base merge * BaseFigure and BasePlotlyType inherit from PlotlyBase class * remove commented validation function * comment out validate error in test_scatter * add histogram2dcontour back to graph_reference TRACES * FigureWidget to OLD_CLASS_NAMES * add update to Data def in graph_objs//remove to_string in test_update * fixed test_offline in optional * test_plotl_mpl fixed * add py36 to core and optional test envs * break up datetime tests into multiple ones for better test control * fixed JSONEncoding errors * last assert test in test_utils * print statements for testing xaxis1 * construct paths to choropleth files intelligently * update the changelog * bump version * changelog comments * revert to current basedatatypes from #942 * write in helper function for assert_dict_equal * fix trisurf: hoverinfo needs 'none', not 'None' * finished a few more classes in figure_factory tests * remove comment * change error msg for pip installs in choropleth * changelog update * fixed facet grid - annotations now tuples - FacetGrid tests in test_optional * remove DeprecationWarning from _dendrogram.py * remove unneeded comments in facet_grid * change height, width default to np.inf in _Dendogram * fixed all tests in optional figure_factory * PEP8 to greyscale list * fix Quiver tests; remove commented TestDisplot for duplicate * minor test fixes in test_tools resolved * playing around with matplotlylib - no success * chelsea's comment * fixed test_validate tests in test_core * fixed offline tests * change assert error in decorator * flawed annotations dont return error, so not checking for one * fix minor tests in test_data * fix test_error_bars * null changes * added white space * rework mock import for Py3.3+ compat * deepcopy in assert_fig_equal * fixed all but one test in make_subplots * fixed test_api - mock compatib issue * change errortype to ValueError to fix test * fix merge for rebase continue * reverted back to old test in test_figure * validators update * fix test_graph_objs.py in test_core * fix scatter.py * fix self.assert_fig_equal(ohlc.to_plotly_json()['data'][0], * assert_dict_equal typo * fix PotlyError -> ValueError for TestTable class * middle of putting .to_plotly_json in assert_fig_equal * updated test_tools - numpy arrays to lists * test_datetimes fixes * Fix typo (agruments) * test_offline changes * do not strip fig of invalid elements wen running .get_figure\nthis is consistent with favoring validation failure to user\nrelated to TODO #283 Issue\n new valid charts created from old PlotlyImageTest examples * xaxis -> xaxis1 in make_subplots * xaxis -> xaxis1 * test_plot * fixed test_figure * fixed test_append_trace - added assert_fig_equal func clone in test_core * fixed TestDistplot tests * removed test_plotly_base_classes test as PlotlyDict/PlotlyList are removed * fixed tests in test_ff in optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #941 and makes it possible to
import plotly.figure_factorywithout havingpandasinstalled. The general framework for this seems to be used throughout the figure factory code, so presumably the lack of it in this case was a simple oversight.