-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ab_glyph
font backend
#311
Add ab_glyph
font backend
#311
Conversation
Hi there, sorry for a long delay. This is very helpful, and I just rebased the code. Just wondering if you are still interested in working on this PR, if yes I can send a PR to you for the rebase, otherwise I am going to work on my branch to finish this. Please check https://github.com/plotters-rs/plotters/tree/ab_glyph_font_backend for the rebase Thanks for the contribution and please don't mind the delay! |
Yes! I'm absolutely still interested in working on this. |
Thanks a lot for working on this! I am using plotters in my home automation system which runs on a Pi. Without |
7542eec
to
caca096
Compare
I just did a clean interactive rebase against master, after staring at the changes and your own rebased branch. |
I have a branch here which fixes the vertical alignment of glyphs. |
Cool. I've tested it in my case and it looks like it works, so I'll go ahead and pull your branch here. |
I gave up on trying to refactor things to avoid the panic reliance, and just added a buffer instead. As of now, this branch is functional enough to merge. It works where I've been using it (just as it has for... a while). |
I've now added support for passing a |
I've renamed the |
Woops, those Clippy warnings tipped me off to my having forgotten to do the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great if all clippy warnings were fixed, but for me everything looks good. Maybe @38 can have a look too.
I just tried this out it works perfect on my side. And this makes us away from libfontconfig dependency which has frequently asked by many people. It would be nice if you have the clippy warning fixed. Besides that everything looks good to me. Thanks for the awesome work! |
Thanks! |
I've been using
plotters
in a situation where caring about system fonts is unimportant, and havingfont-kit
in my dependency tree has been causing me unnecessary problems. This PR introduces a feature gated font rendering backend based on https://github.com/alexheretic/ab-glyph, which doesn't have those problems for me.I am willing to restructure or completely rewrite this code as necessary to get some form of this feature merged- I can't say I'm certain this is the best API for it.
I can also, and probably should also, add documentation and tests for it. Lemme know what you think is best and I'll do it.