Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unaligned read/write in bitmap backend. #467

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Fix unaligned read/write in bitmap backend. #467

merged 5 commits into from
Apr 20, 2023

Conversation

Berrysoft
Copy link
Contributor

Fixes #461

@Berrysoft Berrysoft changed the title Fix unaligned write in bitmap backend. Fix unaligned read/write in bitmap backend. Apr 20, 2023
@nbdd0121
Copy link

Please fix the reliance on tuple layout as well (i.e. change (u64, u64, u64) to [u64; 3])

AaronErhardt
AaronErhardt approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@AaronErhardt AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you check whether the next-release-devel branch that's used for the upcoming version is also affected?

@AaronErhardt AaronErhardt merged commit c34fcc0 into plotters-rs:master Apr 20, 2023
@Berrysoft Berrysoft deleted the fix/unaligned branch April 20, 2023 19:40
@Berrysoft
Copy link
Contributor Author

@AaronErhardt yes, it is also affected.

@AaronErhardt
Copy link
Member

Would you mind sending a PR for that branch as well?

@Berrysoft
Copy link
Contributor Author

I've opened a PR: #469

@saethlin saethlin mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronErhardt AaronErhardt AaronErhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Panic in unsafe fill_rect_fast
3 participants
@Berrysoft @nbdd0121 @AaronErhardt