Relax too strict life times on ChartBuilder #610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChartBuilder
's lifetimes meant that theroot_area
was not allowed to be dropped after the builder has been finalised (i.e. with a call tobuild_cartesian_2d
). I'm not 100% sure but this feels like unintended behaviour.Since the
root_area
is cloned and no references to the original (usuallyroot
DrawingArea) are maintained by the resultingChartContext
this lifetime can be relaxed.This should allow for
ChartContext
s to outlive theroot
drawing areas.