Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18 support #2204

Closed
wants to merge 3 commits into from
Closed

Node 18 support #2204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2907ca8
Node 18 support
piwysocki Dec 19, 2022
a245c39
sandbox
piwysocki Dec 19, 2022
00ec9a3
ts-node
piwysocki Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codesandbox/ci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"buildCommand": false,
"packages": ["packages/*"],
"sandboxes": ["/examples/codesandbox", "/website"],
"node": "16"
"node": "18"
}
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['16']
node-version: [16, 18]
steps:
- name: Check out code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -26,15 +26,15 @@ jobs:
run: echo "::set-output name=dir::$(yarn cache dir)"

- name: Restore Yarn cache
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-

- name: Restore Lerna cache
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: |
node_modules
Expand Down
4 changes: 2 additions & 2 deletions api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"engineStrict": true,
"engines": {
"node": "16.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not: >=16.x

Changing to 18.x would make users of node 16 not being able to import the library anymore. >=16.x seems to be a better compromise.

"node": "18.x"
},
"devDependencies": {
"nodemon": "^1.18.10"
Expand All @@ -26,7 +26,7 @@
"@types/body-parser": "^1.19.2",
"@types/cors": "^2.8.12",
"@types/express": "^4.17.13",
"@types/node": "^16.11.12",
"@types/node": "^18.11.17",
"body-parser": "^1.17.2",
"compression": "^1.7.0",
"cors": "2.8.5",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
"website"
],
"engines": {
"node": "16.x"
"node": "18.x"
},
"devDependencies": {
"@storybook/addon-essentials": "^6.4.9"
Expand Down
2 changes: 1 addition & 1 deletion website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@
"serve": "gatsby serve"
},
"engines": {
"node": "16.x"
"node": "18.x"
}
}
Loading