-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/export responsive bar props TypeScript types #2396
feat/export responsive bar props TypeScript types #2396
Conversation
People can use them, if it's not just an inline Omit type
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 573ee8c:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've an issue were is being typed as:
Note the But if I open the actual file with the type definition it seems correct:
Started happening after updating |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@nivo/axes](https://github.com/plouc/nivo) ([source](https://github.com/plouc/nivo/tree/HEAD/packages/axes)) | [`0.83.0` -> `0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2faxes/0.83.0/0.84.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2faxes/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2faxes/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2faxes/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2faxes/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/bar](https://github.com/plouc/nivo) ([source](https://github.com/plouc/nivo/tree/HEAD/packages/bar)) | [`0.83.0` -> `0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fbar/0.83.0/0.84.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fbar/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fbar/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fbar/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fbar/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/core](https://github.com/plouc/nivo) ([source](https://github.com/plouc/nivo/tree/HEAD/packages/core)) | [`0.83.0` -> `0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fcore/0.83.0/0.84.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fcore/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fcore/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fcore/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fcore/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/line](https://github.com/plouc/nivo) ([source](https://github.com/plouc/nivo/tree/HEAD/packages/line)) | [`0.83.0` -> `0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fline/0.83.0/0.84.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fline/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fline/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fline/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fline/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/pie](https://github.com/plouc/nivo) ([source](https://github.com/plouc/nivo/tree/HEAD/packages/pie)) | [`0.83.0` -> `0.84.0`](https://renovatebot.com/diffs/npm/@nivo%2fpie/0.83.0/0.84.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@nivo%2fpie/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@nivo%2fpie/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@nivo%2fpie/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@nivo%2fpie/0.83.0/0.84.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>plouc/nivo (@​nivo/axes)</summary> ### [`v0.84.0`](https://github.com/plouc/nivo/releases/tag/v0.84.0) [Compare Source](https://github.com/plouc/nivo/compare/v0.83.1...v0.84.0) ##### What's Changed - fix(bar): use readonly arrays for props as the library does not modif… by [@​pcorpet](https://github.com/pcorpet) in [https://github.com/plouc/nivo/pull/2377](https://github.com/plouc/nivo/pull/2377) - fix(pie): use readonly arrays for props as the library does not modif… by [@​pcorpet](https://github.com/pcorpet) in [https://github.com/plouc/nivo/pull/2431](https://github.com/plouc/nivo/pull/2431) - Fix Bar SSR by [@​OleksandrRakovets](https://github.com/OleksandrRakovets) in [https://github.com/plouc/nivo/pull/2464](https://github.com/plouc/nivo/pull/2464) - Pie: Add the ability to programmatically control the activeId by [@​plouc](https://github.com/plouc) in [https://github.com/plouc/nivo/pull/2465](https://github.com/plouc/nivo/pull/2465) ##### New Contributors - [@​pcorpet](https://github.com/pcorpet) made their first contribution in [https://github.com/plouc/nivo/pull/2377](https://github.com/plouc/nivo/pull/2377) - [@​OleksandrRakovets](https://github.com/OleksandrRakovets) made their first contribution in [https://github.com/plouc/nivo/pull/2464](https://github.com/plouc/nivo/pull/2464) **Full Changelog**: plouc/nivo@v0.83.1...v0.84.0 ### [`v0.83.1`](https://github.com/plouc/nivo/releases/tag/v0.83.1) [Compare Source](https://github.com/plouc/nivo/compare/v0.83.0...v0.83.1) ##### What's Changed - [@​nivo/parallel-coordinates](https://github.com/nivo/parallel-coordinates) next by [@​plouc](https://github.com/plouc) in [https://github.com/plouc/nivo/pull/2329](https://github.com/plouc/nivo/pull/2329) - Add tests for gradients attribute by [@​hyjoong](https://github.com/hyjoong) in [https://github.com/plouc/nivo/pull/2338](https://github.com/plouc/nivo/pull/2338) - fix: Lodash - use module imports by [@​vio](https://github.com/vio) in [https://github.com/plouc/nivo/pull/2349](https://github.com/plouc/nivo/pull/2349) - Resolved BoxPlot types not being included in build output by [@​NicolasNewman](https://github.com/NicolasNewman) in [https://github.com/plouc/nivo/pull/2351](https://github.com/plouc/nivo/pull/2351) - Fix website component search by [@​aautem](https://github.com/aautem) in [https://github.com/plouc/nivo/pull/2371](https://github.com/plouc/nivo/pull/2371) - fix: waffle types missing from dist by [@​brammitch](https://github.com/brammitch) in [https://github.com/plouc/nivo/pull/2375](https://github.com/plouc/nivo/pull/2375) - Fix arcLinkLabelsOffset for pie chart by [@​aautem](https://github.com/aautem) in [https://github.com/plouc/nivo/pull/2369](https://github.com/plouc/nivo/pull/2369) - feat/export responsive bar props TypeScript types by [@​ollwenjones](https://github.com/ollwenjones) in [https://github.com/plouc/nivo/pull/2396](https://github.com/plouc/nivo/pull/2396) - fix(stream): fix stream diagram overflowing by [@​baldulin](https://github.com/baldulin) in [https://github.com/plouc/nivo/pull/2392](https://github.com/plouc/nivo/pull/2392) - fix GitHub workflow badge URL by [@​shoito](https://github.com/shoito) in [https://github.com/plouc/nivo/pull/2453](https://github.com/plouc/nivo/pull/2453) - Fix failing builds by [@​plouc](https://github.com/plouc) in [https://github.com/plouc/nivo/pull/2460](https://github.com/plouc/nivo/pull/2460) - shiftArray in calendar/src/compute/timeRange.ts should not mutate its argument by [@​wirhabenzeit](https://github.com/wirhabenzeit) in [https://github.com/plouc/nivo/pull/2420](https://github.com/plouc/nivo/pull/2420) - fix(core): upgrade d3-interpolate and d3-scale-chromatic by [@​plouc](https://github.com/plouc) in [https://github.com/plouc/nivo/pull/2461](https://github.com/plouc/nivo/pull/2461) - Feature/bar chart truncate axes ticks by [@​SebasQuirogaUCP](https://github.com/SebasQuirogaUCP) in [https://github.com/plouc/nivo/pull/2405](https://github.com/plouc/nivo/pull/2405) - feat(legends): export SymbolProps by [@​plouc](https://github.com/plouc) in [https://github.com/plouc/nivo/pull/2462](https://github.com/plouc/nivo/pull/2462) ##### New Contributors - [@​hyjoong](https://github.com/hyjoong) made their first contribution in [https://github.com/plouc/nivo/pull/2338](https://github.com/plouc/nivo/pull/2338) - [@​vio](https://github.com/vio) made their first contribution in [https://github.com/plouc/nivo/pull/2349](https://github.com/plouc/nivo/pull/2349) - [@​NicolasNewman](https://github.com/NicolasNewman) made their first contribution in [https://github.com/plouc/nivo/pull/2351](https://github.com/plouc/nivo/pull/2351) - [@​aautem](https://github.com/aautem) made their first contribution in [https://github.com/plouc/nivo/pull/2371](https://github.com/plouc/nivo/pull/2371) - [@​baldulin](https://github.com/baldulin) made their first contribution in [https://github.com/plouc/nivo/pull/2392](https://github.com/plouc/nivo/pull/2392) - [@​shoito](https://github.com/shoito) made their first contribution in [https://github.com/plouc/nivo/pull/2453](https://github.com/plouc/nivo/pull/2453) - [@​wirhabenzeit](https://github.com/wirhabenzeit) made their first contribution in [https://github.com/plouc/nivo/pull/2420](https://github.com/plouc/nivo/pull/2420) - [@​SebasQuirogaUCP](https://github.com/SebasQuirogaUCP) made their first contribution in [https://github.com/plouc/nivo/pull/2405](https://github.com/plouc/nivo/pull/2405) **Full Changelog**: plouc/nivo@v0.83.0...v0.83.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sebald/pattern-analyzer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
People can use them if it's not just an inline Omit type.