🐛 [#2597] Prevent Line Chart from crashing when having no data #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@akassaei, thank you for your contribution! |
|
Thanks a lot for the review and the time that you put in this project @plouc 🙏 ❤️ |
venky-0710
pushed a commit
to anarock/nivo
that referenced
this pull request
Dec 4, 2024
…ouc#2669) * fix + test * test refacto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue described on #2597
The issue we had was that we are calling
delaunay.findfunction on empty data, it was fixed on their side but new version was not deployed yet so we still need to make a fix around this.The simple fix I found was to early return when we have
nodes.length === 0.I've also added a simple test around Line Chart