fix [hack] for crash when dragging a tab to the right edge of a tabbar from another tabbar. #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r from another tabbar. We need to have our own TabButtonBar, that is able to work correctly with DnD & Overflow This fix forces all tabs dragged into the right edge of a tabbar to be added before the last. Which stops the index being incorrect if the the tabbar goes into overflow.
… not 3, so take that into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to have our own TabButtonBar, that is able to work correctly with DnD & Overflow
This fix forces all tabs dragged into the right edge of a tabbar to be added before the last. Which stops the index being incorrect if the the tabbar goes into overflow, with the caveat that it may not look correct when tabs move with animating.