Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various canvas fixes #1187

Merged

Conversation

AlexMitchellMus
Copy link
Collaborator

@AlexMitchellMus AlexMitchellMus commented Sep 17, 2023

  • fix IEM labels not updating correctly when changed (canvas used PD label text- which could change 'after' the label has been set via message snooping)
    ⚠️ Label updates has a jitter, so they don't update consistently, when they are being updated at a fixed rate (60hz etc), looks like this may come from the snooping system itself?
  • fix connection display not showing extended characters (don't use monospace) show how many items are in a list for connection display
  • fix moving objects reading PD bounds 'as they are being dragged'

with fix:

Peek.2023-09-17.21-01.mp4

without fix:

Peek.2023-09-17.21-03.mp4
Test patch (from @tomara-x) :

#N canvas 827 239 527 327 12;
#X msg -513 396 label \$1, f 17;
#X obj -513 438 bng 127 250 50 0 empty empty ☢️ 75 81 0 32 #181818 #181818 #ffea00;
#X obj -513 114 t b f b, f 16;
#X msg -513 246 adddollar \$1, f 21;
#X msg -513 296 set symbol, f 20;
#X msg -513 164 list 👻 🧵 🪡 🦋 🦀 🐐 🍀 🍄 🌕 🌖 🌗 🌘 🌑 🌒 🌓 🌔 🌟 💧 🎷 🎲 🚁 🐭 🔪 🪞 🧿 🧹 🩸 🪱 🧸 💜 ☮ 🆘 🆒 🆓 🖤 ⚧ ☢️ ☣️ 🦊 💎 🐶 🦝 🔮 🦈 🌸 🍑 🥦 🦗 🦐 🍤 🐛 🐠 🫧 🤍 🐸 🐍 🌊 🍡 🍠 🍥 🍙 🍰 🌠 🦞 🪸 🐞 🪲 🐌 🕊 🌿 🎱 🐳 💕 💋 🍧 🥥 ☄️ ☀️ 🐜 🦑 🪓 🕸 🧭 🎑 🌅 🌄 🌠 🎇 🎆 🌇 🌆 🌃 🌌 🌉 🌁, f 99;
#X obj -513 14 metro 1 60 persec, f 25;
#X obj -513 64 count 1 95, f 19;
#X obj -513 -62 tgl 46 0 empty empty empty 17 7 0 10 #191919 #d4d4d4 #d4d4d4 0 1;
#X msg -513 346 symbol \$37, f 12;
#X connect 0 0 1 0;
#X connect 2 0 5 0;
#X connect 2 1 3 0;
#X connect 2 2 4 0;
#X connect 3 0 9 0;
#X connect 4 0 9 0;
#X connect 5 0 9 0;
#X connect 6 0 7 0;
#X connect 7 0 2 0;
#X connect 8 0 6 0;
#X connect 9 0 0 0;

fix connection display not showing extended characters (don't use monospace)
show how many items are in a list for connection display
fix moving objects reading PD bounds 'as they are being dragged'
@timothyschoen timothyschoen merged commit 400ce81 into plugdata-team:main Sep 20, 2023
@AlexMitchellMus AlexMitchellMus deleted the fix-various-canvas-issues branch September 25, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants