-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jack4all #2005
base: develop
Are you sure you want to change the base?
Feature/jack4all #2005
Conversation
* use modded juce * fix imports * move JUCE_JACK out of other if tree * jack4all * use new JUCE commit; install jack with homebrew * use proper include path on macOS * specify different include dirs for macOS * Feature/jack4all juce winget (#4) * install winget and jack2 on windews. add MSVC include path * try windows tricks * HMODULE --------- Co-authored-by: dromer <dreamer@mrtoasted.com>
One Windows user confirmed that it works :) |
Changes have been applied to upstream JUCE develop branch, so they will come to us when we sync up with them. |
Nice! Perhaps I should merge it into my fork sooner, because we're not moving to JUCE 8 soon. It has some regressions (text rendering performance especially) that affect us. |
@timothyschoen yeah I talked to @alcomposer about it. They didn't take my exact commit, but their additional changes are minimal (docstring and formatting). This code is years old so should work fine on 7 as well. Btw moving to JUCE 8 changes the license to AGPL-3.0 - so this may require additional agreement from any contributors. |
So this wasn't too hard after all.
Still needs proper confirmation/test on Windows, but this should work correctly.
We should probably merge the JUCE change first though (if the team decides to support this).
Closes #1989