Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jack4all #2005

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

dromer
Copy link
Contributor

@dromer dromer commented Dec 5, 2024

So this wasn't too hard after all.

Still needs proper confirmation/test on Windows, but this should work correctly.

We should probably merge the JUCE change first though (if the team decides to support this).

Closes #1989

dromer and others added 5 commits December 2, 2024 13:49
* use modded juce

* fix imports

* move JUCE_JACK out of other if tree

* jack4all

* use new JUCE commit; install jack with homebrew

* use proper include path on macOS

* specify different include dirs for macOS

* Feature/jack4all juce winget (#4)

* install winget and jack2 on windews. add MSVC include path

* try windows tricks

* HMODULE

---------

Co-authored-by: dromer <dreamer@mrtoasted.com>
@dromer dromer marked this pull request as draft December 5, 2024 14:49
@dromer
Copy link
Contributor Author

dromer commented Dec 6, 2024

One Windows user confirmed that it works :)

@dromer
Copy link
Contributor Author

dromer commented Dec 12, 2024

Changes have been applied to upstream JUCE develop branch, so they will come to us when we sync up with them.

@timothyschoen
Copy link
Collaborator

Changes have been applied to upstream JUCE develop branch, so they will come to us when we sync up with them.

Nice! Perhaps I should merge it into my fork sooner, because we're not moving to JUCE 8 soon. It has some regressions (text rendering performance especially) that affect us.

@dromer
Copy link
Contributor Author

dromer commented Dec 12, 2024

@timothyschoen yeah I talked to @alcomposer about it. They didn't take my exact commit, but their additional changes are minimal (docstring and formatting).

This code is years old so should work fine on 7 as well.

Btw moving to JUCE 8 changes the license to AGPL-3.0 - so this may require additional agreement from any contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: jack option on macOS
2 participants