Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core v Beta progress update #361

Merged
merged 21 commits into from
Mar 7, 2023
Merged

Core v Beta progress update #361

merged 21 commits into from
Mar 7, 2023

Conversation

CoMPaTech
Copy link
Member

@CoMPaTech CoMPaTech commented Mar 4, 2023

Following https://plugwise.github.io/progress/diff.html

Adding # pw-beta tags where appropriate to ease up differences

PR is also meant as a step-up to see if we can carve out a way for the Core Team to decide on embedding USB into the Core Plugwise environment. E.g. making sure the 'mammoth' that is now https://plugwise.github.io/progress/diff.html can be used as an oversight and from that we can chunk PRs in a relative quick pace to ensure we embed USB within a month between releases. As such re-breathing live into Core PR 35713

Checklist as per Progress diff core/beta beginning of March 2023: (note that all COORDINATOR relations are under coordinator.py to not re-iterate across all domains)

  • USB plugwise/__init__.py replaces placeholders when upstreaming
  • Generic/USB plugwise/binary_sensor.py``dataclass structure needs conformance/decision between beta and core
  • Generic plugwise/climate.py though mainly 'options' which won't upstream
  • USB plugwise/config_flow.py foremost USB flow handling + some exceptions
  • Generic/USB plugwise/const.py const & dataclass
  • Generic plugwise/coordinator.py untouched, needs alignment between beta and core
  • Generic plugwise/diagnostics.py *) except coordinator
  • Generic plugwise/entity.py only isorted
  • Generic plugwise/gateway.py mostly beta-only related things
  • Generic plugwise/manifest.json no actions needed specifically
  • Generic plugwise/number.py needs alignment
  • Generic plugwise/select.py *) except coordinator
  • Generic/USB plugwise/sensor.py dataclass structure needs conformance/decision between beta and core
  • USB plugwise/strings.json
  • USB plugwise/switch.py
  • Generic plugwise/util.py

@CoMPaTech CoMPaTech added the downstreaming Things that are changed on HA-core side and to be applied to -beta label Mar 4, 2023
@CoMPaTech CoMPaTech self-assigned this Mar 4, 2023
@CoMPaTech CoMPaTech changed the title First batch of core-vs-beta Core v Beta progress update Mar 4, 2023
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change/revert as indicated in the single comments.

@CoMPaTech CoMPaTech added documentation Improvements or additions to documentation enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core labels Mar 4, 2023
@CoMPaTech
Copy link
Member Author

I think this is most of the tagging to be done (e.g. translations et such is not that much of an issue. Wrt const and the domain files, we should decide/catch-up either end wrt the entities.

@CoMPaTech
Copy link
Member Author

Initial comment updated, cc @brefra

@bouwew
Copy link
Contributor

bouwew commented Mar 5, 2023

👍

@CoMPaTech
Copy link
Member Author

Added checklist

@CoMPaTech CoMPaTech marked this pull request as ready for review March 5, 2023 20:51
@CoMPaTech CoMPaTech requested a review from a team as a code owner March 5, 2023 20:51
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoMPaTech
Copy link
Member Author

Added plugwise/plugwise_usb-beta#13 to keep comments

@CoMPaTech CoMPaTech merged commit cf8c42f into main Mar 7, 2023
CoMPaTech added a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation downstreaming Things that are changed on HA-core side and to be applied to -beta enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants