-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core v Beta progress update #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change/revert as indicated in the single comments.
I think this is most of the tagging to be done (e.g. translations et such is not that much of an issue. Wrt |
Initial comment updated, cc @brefra |
👍 |
Added checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added plugwise/plugwise_usb-beta#13 to keep comments |
Following https://plugwise.github.io/progress/diff.html
Adding
# pw-beta
tags where appropriate to ease up differencesPR is also meant as a step-up to see if we can carve out a way for the Core Team to decide on embedding USB into the Core Plugwise environment. E.g. making sure the 'mammoth' that is now https://plugwise.github.io/progress/diff.html can be used as an oversight and from that we can chunk PRs in a relative quick pace to ensure we embed USB within a month between releases. As such re-breathing live into Core PR 35713
Checklist as per Progress diff core/beta beginning of March 2023: (note that all
COORDINATOR
relations are undercoordinator.py
to not re-iterate across all domains)plugwise/__init__.py
replaces placeholders when upstreamingplugwise/binary_sensor.py``dataclass
structure needs conformance/decision between beta and coreplugwise/climate.py
though mainly 'options' which won't upstreamplugwise/config_flow.py
foremost USB flow handling + some exceptionsplugwise/const.py
const & dataclassplugwise/coordinator.py
untouched, needs alignment between beta and coreplugwise/diagnostics.py
*) except coordinatorplugwise/entity.py
only isortedplugwise/gateway.py
mostly beta-only related thingsplugwise/manifest.json
no actions needed specificallyplugwise/number.py
needs alignmentplugwise/select.py
*) except coordinatorplugwise/sensor.py
dataclass
structure needs conformance/decision between beta and coreplugwise/strings.json
plugwise/switch.py
plugwise/util.py