Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Code quality #107

Open
CoMPaTech opened this issue Dec 24, 2023 · 0 comments
Open

[BUG]: Code quality #107

CoMPaTech opened this issue Dec 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@CoMPaTech
Copy link
Member

CoMPaTech commented Dec 24, 2023 •
edited
Loading

Describe the bug.

Replacing black with ruff not viable yet - also mypy and coverage (as there is lack of testing for prolonged time now) #106 prepared this but ruff is effectively disabled in .github/workflows/verify now.

Disabled in pre-commit and GH action verify

Expected behavior

Ensure proper code along HA standards

Todo

  • [] Make code ruff compatible
  • [] Make code mypy compatible
  • [] Finally make some tests so we have coverage to test for
@CoMPaTech CoMPaTech added the bug Something isn't working label Dec 24, 2023
This was referenced Dec 24, 2023
Closed
Open
CoMPaTech added a commit that referenced this issue Feb 1, 2024
@CoMPaTech
Re-try #107
b08e076
CoMPaTech added a commit that referenced this issue Feb 1, 2024
@CoMPaTech
Re-try #107
08b99b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CoMPaTech