Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to energy_consumption_hour #125

Merged
merged 14 commits into from
Jan 3, 2024
Merged

Fixes to energy_consumption_hour #125

merged 14 commits into from
Jan 3, 2024

Conversation

dirixmjm
Copy link
Contributor

@dirixmjm dirixmjm commented Jan 3, 2024

Ratelimit EnergyCountersRequest to maximally every minute
Automatic restart EnergyCountersRequest if energy_consumption_hourly is None.
Automatic repeat missing log_adresses.

@dirixmjm dirixmjm requested a review from a team as a code owner January 3, 2024 15:39
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (58472a7) 35.00% compared to head (19da5a6) 34.85%.

Files Patch % Lines
plugwise_usb/nodes/circle.py 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   35.00%   34.85%   -0.15%     
==========================================
  Files          21       21              
  Lines        2414     2424      +10     
==========================================
  Hits          845      845              
- Misses       1569     1579      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@bouwew bouwew merged commit 22a1fec into plugwise:main Jan 3, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants